Enhance documentation for URL attachments. #1262
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enhance documentation for [`Attachment.init(contentsOf:named:sourceLocation:)`](https://developer.apple.com/documentation/testing/attachment/init(contentsof:named:sourcelocation:)). In particular, provide info on what kind of URLs can be passed in, what the initializer awaits on, and how to use this (since there's intentionally no equivalent `record()` overload.) Resolves #1255.
grynspan
added
attachments/activities
stmontgomery
approved these changes
Aug 11, 2025
iamleeg
approved these changes
Aug 12, 2025
Sources/Overlays/_Testing_Foundation/Attachments/Attachment+URL.swift
Outdated
Show resolved
Hide resolved
Sources/Overlays/_Testing_Foundation/Attachments/Attachment+URL.swift
Outdated
Show resolved
Hide resolved
Sources/Overlays/_Testing_Foundation/Attachments/Attachment+URL.swift
Outdated
Show resolved
Hide resolved
…L.swift Co-authored-by: Graham Lee <[email protected]>
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhance documentation for
Attachment.init(contentsOf:named:sourceLocation:). In particular, provide info on what kind of URLs can be passed in, what the initializer awaits on, and how to use this (since there's intentionally no equivalentrecord()overload.)Resolves #1255.
Checklist: